Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 407093014: Fix legalization of source operand to bsr and bsf. (Closed)

Created:
6 years, 5 months ago by wala
Modified:
6 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Fix legalization of source operand to bsr and bsf. The source operand to bsr and bsf must be in a register or memory. BUG=none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=53c5e60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/IceTargetLoweringX8632.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wala
6 years, 5 months ago (2014-07-22 23:16:19 UTC) #1
jvoung (off chromium)
LGTM thanks
6 years, 5 months ago (2014-07-22 23:36:32 UTC) #2
wala
6 years, 5 months ago (2014-07-22 23:39:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r53c5e60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698