Source/core/dom/Node.cpp - Issue 407093010: Simplify compareDocumentPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 407093010: Simplify compareDocumentPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index d76d159367c309d34d6269f5222b207ab1662ddd..60cb213b9afd737659d3559968ac010e5f827e6e 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -1547,12 +1547,7 @@ bool Node::offsetInCharacters() const

return false;

}

-unsigned short Node::compareDocumentPosition(const Node* otherNode) const

- return compareDocumentPositionInternal(otherNode, TreatShadowTreesAsDisconnected);

-unsigned short Node::compareDocumentPositionInternal(const Node* otherNode, ShadowTreesTreatment treatment) const

+unsigned short Node::compareDocumentPosition(const Node* otherNode, ShadowTreesTreatment treatment) const

{

// It is not clear what should be done if |otherNode| is 0.

if (!otherNode)

« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/dom/StyleEngine.cpp » ('j') | no next file with comments »