Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 407093010: Simplify compareDocumentPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/dom/StyleEngine.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1529 matching lines...) Expand 10 before | Expand all | Expand 10 after
1540 return; 1540 return;
1541 } 1541 }
1542 ASSERT_NOT_REACHED(); 1542 ASSERT_NOT_REACHED();
1543 } 1543 }
1544 1544
1545 bool Node::offsetInCharacters() const 1545 bool Node::offsetInCharacters() const
1546 { 1546 {
1547 return false; 1547 return false;
1548 } 1548 }
1549 1549
1550 unsigned short Node::compareDocumentPosition(const Node* otherNode) const 1550 unsigned short Node::compareDocumentPosition(const Node* otherNode, ShadowTreesT reatment treatment) const
1551 {
1552 return compareDocumentPositionInternal(otherNode, TreatShadowTreesAsDisconne cted);
1553 }
1554
1555 unsigned short Node::compareDocumentPositionInternal(const Node* otherNode, Shad owTreesTreatment treatment) const
1556 { 1551 {
1557 // It is not clear what should be done if |otherNode| is 0. 1552 // It is not clear what should be done if |otherNode| is 0.
1558 if (!otherNode) 1553 if (!otherNode)
1559 return DOCUMENT_POSITION_DISCONNECTED; 1554 return DOCUMENT_POSITION_DISCONNECTED;
1560 1555
1561 if (otherNode == this) 1556 if (otherNode == this)
1562 return DOCUMENT_POSITION_EQUIVALENT; 1557 return DOCUMENT_POSITION_EQUIVALENT;
1563 1558
1564 const Attr* attr1 = nodeType() == ATTRIBUTE_NODE ? toAttr(this) : 0; 1559 const Attr* attr1 = nodeType() == ATTRIBUTE_NODE ? toAttr(this) : 0;
1565 const Attr* attr2 = otherNode->nodeType() == ATTRIBUTE_NODE ? toAttr(otherNo de) : 0; 1560 const Attr* attr2 = otherNode->nodeType() == ATTRIBUTE_NODE ? toAttr(otherNo de) : 0;
(...skipping 1013 matching lines...) Expand 10 before | Expand all | Expand 10 after
2579 node->showTreeForThis(); 2574 node->showTreeForThis();
2580 } 2575 }
2581 2576
2582 void showNodePath(const blink::Node* node) 2577 void showNodePath(const blink::Node* node)
2583 { 2578 {
2584 if (node) 2579 if (node)
2585 node->showNodePathForThis(); 2580 node->showNodePathForThis();
2586 } 2581 }
2587 2582
2588 #endif 2583 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/dom/StyleEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698