content/browser/web_contents/touch_editable_impl_aura_browsertest.cc - Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | ui/wm/core/nested_accelerator_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

diff --git a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

index e63ce5af8ab5dfe3d49200206b5f7e306564ef51..a44174ebb6d72eaf57a1b8d0b464ddb9baaa22fe 100644

--- a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

+++ b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

@@ -312,8 +312,14 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

EXPECT_STREQ("Some", selection.c_str());

}

+#if defined(OS_CHROMEOS)

+// http://crbug.com/396509

+#define MAYBE_TouchCursorInTextfieldTest DISABLED_TouchCursorInTextfieldTest

+#else

+#define MAYBE_TouchCursorInTextfieldTest TouchCursorInTextfieldTest

+#endif

IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

- TouchCursorInTextfieldTest) {

+ MAYBE_TouchCursorInTextfieldTest) {

ASSERT_NO_FATAL_FAILURE(StartTestWithPage("files/touch_selection.html"));

WebContentsImpl* web_contents =

static_cast<WebContentsImpl*>(shell()->web_contents());