content/browser/service_worker/service_worker_browsertest.cc - Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/process_proxy/process_output_watcher_unittest.cc ('k') | content/browser/web_contents/touch_editable_impl_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index 442a6b943699b8bf912b044475e16b5744a5bd73..0ae1341d7eb69bc50142a08bfcef1075f8f1e835 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -742,8 +742,8 @@ static int CountRenderProcessHosts() {

return result;

}

-// Crashes on Android: http://crbug.com/387045

-#if defined(OS_ANDROID)

+// Crashes on Android and flakes on CrOS: http://crbug.com/387045

+#if defined(OS_ANDROID) || defined(OS_CHROMEOS)

#define MAYBE_Registration DISABLED_Registration

#else

#define MAYBE_Registration Registration