chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/policy_cert_verifier_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 4f64b502291163723934c0805e7a1e35ba338299..556fda4628b77b85c24e650a6b2524ddfee81d1c 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -803,8 +803,14 @@ downloads::InterruptReason InterruptReasonContentToExtension(

} // namespace

+#if defined(OS_CHROMEOS)

+// http://crbug.com/396510

+#define MAYBE_DownloadExtensionTest_Open DISABLED_DownloadExtensionTest_Open

+#else

+#define MAYBE_DownloadExtensionTest_Open DownloadExtensionTest_Open

+#endif

IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

- DownloadExtensionTest_Open) {

+ MAYBE_DownloadExtensionTest_Open) {

LoadExtension("downloads_split");

DownloadsOpenFunction* open_function = new DownloadsOpenFunction();

open_function->set_user_gesture(true);