Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 407073010: Disable all the tests that are flaking more than 5% on ChromeOS builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Disable everything on windows only. http://crbug.com/306144 5 // Disable everything on windows only. http://crbug.com/306144
6 #ifndef OS_WIN 6 #ifndef OS_WIN
7 7
8 #include <algorithm> 8 #include <algorithm>
9 9
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 return downloads::INTERRUPT_REASON_##name; 796 return downloads::INTERRUPT_REASON_##name;
797 #include "content/public/browser/download_interrupt_reason_values.h" 797 #include "content/public/browser/download_interrupt_reason_values.h"
798 #undef INTERRUPT_REASON 798 #undef INTERRUPT_REASON
799 } 799 }
800 NOTREACHED(); 800 NOTREACHED();
801 return downloads::INTERRUPT_REASON_NONE; 801 return downloads::INTERRUPT_REASON_NONE;
802 } 802 }
803 803
804 } // namespace 804 } // namespace
805 805
806 #if defined(OS_CHROMEOS)
807 // http://crbug.com/396510
808 #define MAYBE_DownloadExtensionTest_Open DISABLED_DownloadExtensionTest_Open
809 #else
810 #define MAYBE_DownloadExtensionTest_Open DownloadExtensionTest_Open
811 #endif
806 IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, 812 IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,
807 DownloadExtensionTest_Open) { 813 MAYBE_DownloadExtensionTest_Open) {
808 LoadExtension("downloads_split"); 814 LoadExtension("downloads_split");
809 DownloadsOpenFunction* open_function = new DownloadsOpenFunction(); 815 DownloadsOpenFunction* open_function = new DownloadsOpenFunction();
810 open_function->set_user_gesture(true); 816 open_function->set_user_gesture(true);
811 EXPECT_STREQ(errors::kInvalidId, 817 EXPECT_STREQ(errors::kInvalidId,
812 RunFunctionAndReturnError( 818 RunFunctionAndReturnError(
813 open_function, 819 open_function,
814 "[-42]").c_str()); 820 "[-42]").c_str());
815 821
816 DownloadItem* download_item = CreateSlowTestDownload(); 822 DownloadItem* download_item = CreateSlowTestDownload();
817 ASSERT_TRUE(download_item); 823 ASSERT_TRUE(download_item);
(...skipping 3300 matching lines...) Expand 10 before | Expand all | Expand 10 after
4118 EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_PROMPT, conflict_action); 4124 EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_PROMPT, conflict_action);
4119 EXPECT_FALSE(warnings.empty()); 4125 EXPECT_FALSE(warnings.empty());
4120 EXPECT_EQ(ExtensionWarning::kDownloadFilenameConflict, 4126 EXPECT_EQ(ExtensionWarning::kDownloadFilenameConflict,
4121 warnings.begin()->warning_type()); 4127 warnings.begin()->warning_type());
4122 EXPECT_EQ("incumbent", warnings.begin()->extension_id()); 4128 EXPECT_EQ("incumbent", warnings.begin()->extension_id());
4123 } 4129 }
4124 4130
4125 } // namespace extensions 4131 } // namespace extensions
4126 4132
4127 #endif // http://crbug.com/3061144 4133 #endif // http://crbug.com/3061144
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698