Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 407073008: Revert 284819 because it introduces leaks in TestingBoundaries and (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
Reviewers:
lisayin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284819 because it introduces leaks in TestingBoundaries and EnterSlideGestureState tests in TouchExplorationTest: Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x448b2b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x14703f7 in ui::GestureProviderAura::GetAndResetPendingGestures() ui/events/gestures/gesture_provider_aura.cc:112 #2 0x9f4986 in ui::TouchExplorationController::InSlideGesture(ui::TouchEvent const&, scoped_ptr\u003Cui::Event, base::DefaultDeleter\u003Cui::Event> >*) ui/chromeos/touch_exploration_controller.cc:578 ... etc. > Added side slide gestures to touch exploration controller. > > The user can control settings that might be normally changed using sliders by sliding along the edge of the screen when ChromeVox is on. For example, the user can slide along the right edge of the screen and adjust the volume. > > If the user enters this mode and leaves the boundaries without releasing their touch, they will stop adjusting the setting, however, they will not enter touch exploration. If they return to the given boundaries, they will be able to modify the setting again. If the user does not touch a "hot edge" of the screen, they will not enter this state if they move to the an of the screen. > > BUG=393326 > > Review URL: https://codereview.chromium.org/385073009 TBR=lisayin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -701 lines) Patch
M trunk/src/ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D trunk/src/ash/ash_touch_exploration_manager_chromeos.h View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/ash/ash_touch_exploration_manager_chromeos.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D trunk/src/ash/ash_touch_exploration_manager_chromeos_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M trunk/src/ash/root_window_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/root_window_controller.cc View 4 chunks +52 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chromeos/audio/cras_audio_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chromeos/audio/cras_audio_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/chromeos/touch_exploration_controller.h View 10 chunks +4 lines, -89 lines 0 comments Download
M trunk/src/ui/chromeos/touch_exploration_controller.cc View 13 chunks +8 lines, -181 lines 0 comments Download
M trunk/src/ui/chromeos/touch_exploration_controller_unittest.cc View 8 chunks +4 lines, -250 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 5 months ago (2014-07-23 04:28:34 UTC) #1
sadrul
6 years, 5 months ago (2014-07-23 04:30:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r284849 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698