Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 406953002: Mojo: Don't try to close the child process handle after WaitForExitCode(). (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Don't try to close the child process handle after WaitForExitCode(). WaitForExitCode() closes the process handle itself. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/shell/child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-21 21:44:29 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-21 22:39:15 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 5 months ago (2014-07-21 22:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/406953002/1
6 years, 5 months ago (2014-07-21 22:51:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 23:48:44 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:04:24 UTC) #6
Message was sent while issue was closed.
Change committed as 284575

Powered by Google App Engine
This is Rietveld 408576698