Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: mojo/shell/child_process_host.cc

Issue 406953002: Mojo: Don't try to close the child process handle after WaitForExitCode(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/child_process_host.cc
diff --git a/mojo/shell/child_process_host.cc b/mojo/shell/child_process_host.cc
index e743522e5ff16c757dc7d35948b6b60198eed8f5..5d797586e7c817e314e678299d2baa6345e49822 100644
--- a/mojo/shell/child_process_host.cc
+++ b/mojo/shell/child_process_host.cc
@@ -56,9 +56,9 @@ void ChildProcessHost::Start() {
int ChildProcessHost::Join() {
DCHECK_NE(child_process_handle_, base::kNullProcessHandle);
int rv = -1;
+ // Note: |WaitForExitCode()| closes the process handle.
LOG_IF(ERROR, !base::WaitForExitCode(child_process_handle_, &rv))
<< "Failed to wait for child process";
- base::CloseProcessHandle(child_process_handle_);
child_process_handle_ = base::kNullProcessHandle;
return rv;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698