Issue 4066: Don't defer the stack check failure code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4066: Don't defer the stack check failure code. (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

Don't defer the stack check failure code. It is a CallStub, which will be a single 5 byte call instruction. This should cause equivalent code size now, but opens up the opportunity to make one of the most common jcc's to use short encoding in the future.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -19 lines)			Patch
	M	src/codegen-ia32.cc	View		1 chunk	+5 lines, -19 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

12 years, 3 months ago (2008-09-24 13:04:53 UTC) #1

I imagine this was originally done with some reason, we now have more code in
the main body, where before the stack failure call would have been pushed to the
bottom.  However, we will save 4 bytes when we can use a short jcc, so this will
mean it's only 1 byte more in the main body, and nothing at the end, so I think
it's a definite win.

Expand Messages | Collapse Messages