Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/codegen-ia32.cc

Issue 4066: Don't defer the stack check failure code. (Closed)
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
diff --git a/src/codegen-ia32.cc b/src/codegen-ia32.cc
index 6a522c57988ef2a97ca16d61019c7c62256054b1..ce1bce6fe88c0a8c6855e64aac9517c8b3a99f45 100644
--- a/src/codegen-ia32.cc
+++ b/src/codegen-ia32.cc
@@ -2660,30 +2660,16 @@ void Ia32CodeGenerator::Branch(bool if_true, Label* L) {
}
-class StackCheckDeferred: public DeferredCode {
- public:
- explicit StackCheckDeferred(CodeGenerator* generator)
- : DeferredCode(generator) {
- set_comment("[ StackCheckDeferred");
- }
- virtual void Generate();
-};
-
-
-void StackCheckDeferred::Generate() {
- StackCheckStub stub;
- __ CallStub(&stub);
-}
-
-
void Ia32CodeGenerator::CheckStack() {
if (FLAG_check_stack) {
- StackCheckDeferred* deferred = new StackCheckDeferred(this);
+ Label stack_is_ok;
+ StackCheckStub stub;
ExternalReference stack_guard_limit =
ExternalReference::address_of_stack_guard_limit();
__ cmp(esp, Operand::StaticVariable(stack_guard_limit));
- __ j(below, deferred->enter(), not_taken);
- __ bind(deferred->exit());
+ __ j(above_equal, &stack_is_ok, taken);
+ __ CallStub(&stub);
+ __ bind(&stack_is_ok);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698