Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 406483004: Initial implementation of API WakeLock. (Closed)

Created:
6 years, 5 months ago by redchenko
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, creis+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Initial implementation of API WakeLock. BUG=257511 R=darin

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1162 lines, -0 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/YAOWNERS View 1 chunk +1 line, -0 lines 1 comment Download
A chrome/browser/wake_lock/chrome_wake_lock_permission_context.h View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/chrome_wake_lock_permission_context.cc View 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/chrome_wake_lock_permission_context_factory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/chrome_wake_lock_permission_context_factory.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/wake_lock_infobar_delegate.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/wake_lock_infobar_delegate.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/wake_lock_preference.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/wake_lock/wake_lock_preference.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A content/browser/wake_lock/lock.h View 1 chunk +38 lines, -0 lines 0 comments Download
A content/browser/wake_lock/lock.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_dispatcher_host.h View 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_dispatcher_host.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_manager.h View 1 chunk +43 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_manager.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_web_contents_observer.h View 1 chunk +23 lines, -0 lines 0 comments Download
A content/browser/wake_lock/wake_lock_web_contents_observer.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/wake_lock_messages.h View 1 chunk +27 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/browser_context.h View 2 chunks +2 lines, -0 lines 0 comments Download
A content/public/browser/wake_lock_permission_context.h View 1 chunk +34 lines, -0 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download
A content/renderer/wake_lock_dispatcher.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/renderer/wake_lock_dispatcher.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
redchenko
6 years, 5 months ago (2014-07-18 01:49:36 UTC) #1
PhistucK
https://codereview.chromium.org/406483004/diff/1/chrome/browser/wake_lock/YAOWNERS File chrome/browser/wake_lock/YAOWNERS (right): https://codereview.chromium.org/406483004/diff/1/chrome/browser/wake_lock/YAOWNERS#newcode1 chrome/browser/wake_lock/YAOWNERS:1: redchenko@yandex-team.ru This probably should have been left out? :)
6 years, 5 months ago (2014-07-18 13:07:37 UTC) #2
Ilya Bogdanovich
6 years, 5 months ago (2014-07-18 16:13:27 UTC) #3 
On 2014/07/18 13:07:37, PhistucK wrote:
>
https://codereview.chromium.org/406483004/diff/1/chrome/browser/wake_lock/YAO...
> File chrome/browser/wake_lock/YAOWNERS (right):
> 
>
https://codereview.chromium.org/406483004/diff/1/chrome/browser/wake_lock/YAO...
> chrome/browser/wake_lock/YAOWNERS:1: mailto:redchenko@yandex-team.ru
> This probably should have been left out? :)

Yes, we forgot to remove it :)

Powered by Google App Engine
This is Rietveld 408576698