Issue 406383002: Revert 284766 "Pepper: Simplify TempFile in trusted plugin."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406383002: Revert 284766 "Pepper: Simplify TempFile in trusted plugin." (Closed)

Created:
6 years, 5 months ago by sky

Modified:
6 years, 5 months ago

Reviewers:
teravest

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 284766 "Pepper: Simplify TempFile in trusted plugin." Sorry I had to revert this. It's not because it caused problems, but rather I needed to revert r284684 as it caused problems and your patch touches the same files. > Pepper: Simplify TempFile in trusted plugin. > > This change makes the behavior of internal_handle_ in TempFile easier to reason > about. This change is possible after a large refactoring of PnaclCoordinator > that happened as a result of removing FileDownloader. > > BUG=239656 > R=bbudge@chromium.org > > Review URL: https://codereview.chromium.org/413493002 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284790

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -10 lines)			Patch
M	trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.cc	View	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r284790 (tree was closed).

Expand Messages | Collapse Messages