Issue 413493002: Pepper: Simplify TempFile in trusted plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413493002: Pepper: Simplify TempFile in trusted plugin. (Closed)

Created:
6 years, 5 months ago by teravest

Modified:
6 years, 5 months ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pepper: Simplify TempFile in trusted plugin. This change makes the behavior of internal_handle_ in TempFile easier to reason about. This change is possible after a large refactoring of PnaclCoordinator that happened as a result of removing FileDownloader. BUG=239656 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284766

Patch Set 1 : #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -22 lines)			Patch
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/temporary_file.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/temporary_file.cc	View	1	1 chunk	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bbudge

Could the handle be a constructor param? I couldn't find any obvious reason why not.

6 years, 5 months ago (2014-07-22 17:57:22 UTC) #2

teravest

On 2014/07/22 17:57:22, bbudge wrote: > Could the handle be a constructor param? I couldn't ...

6 years, 5 months ago (2014-07-22 19:13:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/413493002/40001

6 years, 5 months ago (2014-07-22 19:52:00 UTC) #6

teravest

6 years, 5 months ago (2014-07-22 21:06:59 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r284766 (presubmit successful).

Expand Messages | Collapse Messages