Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 406323003: Revert 284684 "Pepper: Delete FileDownloader in trusted plugin." (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284684 "Pepper: Delete FileDownloader in trusted plugin." Reverting as broke chrome and chromeos dbg builders: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32615/steps/browser_tests/logs/SuccessfulLoadUMA [ RUN ] NaClBrowserTestPnacl.SuccessfulLoadUMA Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [18889:18889:0722/130648:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. HTTP server started on http://127.0.0.1:56115... sending server_data: {"host": "127.0.0.1", "port": 56115} (36 bytes) [9:10:0722/130650:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:461: error: attempt to insert into container with an iterator from a different container. Objects involved in the operation: sequence "this" @ 0x0x392ba6c93260 { } iterator "__position" @ 0x0x7fff9ff24e20 { state = past-the-end; references sequence @ 0x0x7fff9ff24e20 } [18889:18938:0722/130651:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7fe4bf491cee base::debug::StackTrace::StackTrace() #1 0x000004af93fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fe4b68074a0 \u003Cunknown> #3 0x7fe4b68b9a43 __poll #4 0x7fe4b76faff6 \u003Cunknown> #5 0x7fe4b76fb124 g_main_context_iteration #6 0x7fe4bf44ff75 base::MessagePumpGlib::Run() #7 0x7fe4bf54b1f0 base::MessageLoop::RunHandler() #8 0x7fe4bf5b18e2 base::RunLoop::Run() #9 0x000004b63969 content::RunThisRunLoop() #10 0x000004b638fa content::RunMessageLoop() #11 0x000004b0ea15 content::JavascriptTestObserver::Run() #12 0x000001312927 NaClBrowserTestBase::RunJavascriptTest() #13 0x000001312a48 NaClBrowserTestBase::RunLoadTest() #14 0x00000130f514 (anonymous namespace)::NaClBrowserTestPnacl_SuccessfulLoadUMA_Test::RunTestOnMai ... > Pepper: Delete FileDownloader in trusted plugin. > > This simplifies PnaclCoordinator considerably and reduces the total > amount of code in the trusted plugin. > > BUG=239656 > > Review URL: https://codereview.chromium.org/393693004 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -431 lines) Patch
M trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc View 6 chunks +62 lines, -179 lines 0 comments Download
M trunk/src/ppapi/api/private/ppb_nacl_private.idl View 2 chunks +22 lines, -14 lines 0 comments Download
D trunk/src/ppapi/api/private/ppp_pexe_stream_handler.idl View 1 chunk +0 lines, -45 lines 0 comments Download
M trunk/src/ppapi/c/private/ppb_nacl_private.h View 4 chunks +22 lines, -15 lines 0 comments Download
D trunk/src/ppapi/c/private/ppp_pexe_stream_handler.h View 1 chunk +0 lines, -59 lines 0 comments Download
A + trunk/src/ppapi/native_client/src/trusted/plugin/callback_source.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h View 6 chunks +25 lines, -13 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 5 chunks +140 lines, -86 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 2 chunks +1 line, -4 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 chunk +17 lines, -6 lines 0 comments Download
M trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
6 years, 5 months ago (2014-07-22 23:09:47 UTC) #1
sky
6 years, 5 months ago (2014-07-22 23:09:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r284791 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698