Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 393693004: Pepper: Delete FileDownloader in trusted plugin. (Closed)

Created:
6 years, 5 months ago by teravest
Modified:
6 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: Delete FileDownloader in trusted plugin. This simplifies PnaclCoordinator considerably and reduces the total amount of code in the trusted plugin. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284684

Patch Set 1 : #

Patch Set 2 : Remove last fixme #

Total comments: 19

Patch Set 3 : fixes for dmichael #

Total comments: 2

Patch Set 4 : remove stale comment #

Patch Set 5 : STL fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -649 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 6 chunks +179 lines, -62 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 2 chunks +14 lines, -22 lines 0 comments Download
A ppapi/api/private/ppp_pexe_stream_handler.idl View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 4 chunks +15 lines, -22 lines 0 comments Download
A ppapi/c/private/ppp_pexe_stream_handler.h View 1 2 3 4 1 chunk +59 lines, -0 lines 0 comments Download
D ppapi/native_client/src/trusted/plugin/callback_source.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ppapi/native_client/src/trusted/plugin/file_downloader.h View 1 chunk +0 lines, -125 lines 0 comments Download
D ppapi/native_client/src/trusted/plugin/file_downloader.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h View 1 2 6 chunks +13 lines, -25 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 1 2 3 4 5 chunks +88 lines, -141 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 2 3 4 1 chunk +4 lines, -16 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/temporary_file.h View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/temporary_file.cc View 1 2 3 4 1 chunk +3 lines, -10 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
teravest
Dave, Mind skimming over this one? There's still at least one FIXME left, but I'd ...
6 years, 5 months ago (2014-07-15 20:09:42 UTC) #1
dmichael (off chromium)
Haven't looked super carefully yet. I think the approach seems fine. The PPP interface looks ...
6 years, 5 months ago (2014-07-15 21:51:55 UTC) #2
teravest
Moving PexeDownloader to its own file will be a little annoying, because then GetNexeFd() should ...
6 years, 5 months ago (2014-07-16 16:07:29 UTC) #3
teravest
I've removed the other FIXME. I think this is worth reviewing as is-- PexeDownloader isn't ...
6 years, 5 months ago (2014-07-16 18:30:00 UTC) #4
dmichael (off chromium)
https://codereview.chromium.org/393693004/diff/80001/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/393693004/diff/80001/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode593 components/nacl/renderer/ppb_nacl_private_impl.cc:593: std::string GetCpuFeatureAttrs() { Maybe it would make sense to ...
6 years, 5 months ago (2014-07-17 16:13:21 UTC) #5
teravest
https://codereview.chromium.org/393693004/diff/80001/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/393693004/diff/80001/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode593 components/nacl/renderer/ppb_nacl_private_impl.cc:593: std::string GetCpuFeatureAttrs() { On 2014/07/17 16:13:21, dmichael wrote: > ...
6 years, 5 months ago (2014-07-21 18:33:22 UTC) #6
dmichael (off chromium)
lgtm https://codereview.chromium.org/393693004/diff/80001/ppapi/api/private/ppp_pexe_stream_handler.idl File ppapi/api/private/ppp_pexe_stream_handler.idl (right): https://codereview.chromium.org/393693004/diff/80001/ppapi/api/private/ppp_pexe_stream_handler.idl#newcode14 ppapi/api/private/ppp_pexe_stream_handler.idl:14: M25 = 1.0 On 2014/07/21 18:33:21, teravest wrote: ...
6 years, 5 months ago (2014-07-21 19:49:22 UTC) #7
teravest
https://codereview.chromium.org/393693004/diff/100001/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right): https://codereview.chromium.org/393693004/diff/100001/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc#newcode419 ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:419: // If we don't know the expected total yet, ...
6 years, 5 months ago (2014-07-21 19:54:21 UTC) #8
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-21 19:54:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/393693004/120001
6 years, 5 months ago (2014-07-21 19:59:12 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 00:30:55 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 01:42:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173271)
6 years, 5 months ago (2014-07-22 01:42:57 UTC) #13
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-22 03:02:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/393693004/120001
6 years, 5 months ago (2014-07-22 03:03:13 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 04:15:12 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 05:30:39 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173321)
6 years, 5 months ago (2014-07-22 05:30:41 UTC) #18
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-22 12:39:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/393693004/120001
6 years, 5 months ago (2014-07-22 12:40:01 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 13:51:18 UTC) #21
commit-bot: I haz the power
Change committed as 284684
6 years, 5 months ago (2014-07-22 15:54:49 UTC) #22
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-23 16:14:11 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/393693004/140001
6 years, 5 months ago (2014-07-23 16:15:33 UTC) #24
teravest
6 years, 5 months ago (2014-07-23 17:01:06 UTC) #25
On 2014/07/23 16:15:33, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/teravest@chromium.org/393693004/140001

Committed as 284961.
(git cl dcommit failed locally and therefore didn't update this issue)

Powered by Google App Engine
This is Rietveld 408576698