Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 406183002: Revert of cc: Change TileManager iterators to be queues. (Closed)

Created:
6 years, 5 months ago by Kunihiko Sakamoto
Modified:
6 years, 5 months ago
Reviewers:
reveman, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Change TileManager iterators to be queues. (https://codereview.chromium.org/406543003/) Reason for revert: TileManagerTilePriorityQueueTest.EvictionTilePriorityQueueWithOcclusion consistently times out on Win7 bot http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/29899 Original issue's description: > cc: Change TileManager iterators to be queues. > > This patch is mostly just moving code around. It moves the iterators > from tile manager to be in separate files, renames them to be queues. > > It also adds a tile manager client interface for building the queues. > > The rest is just fix ups for the tests. > > R=reveman > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284506 TBR=reveman@chromium.org,vmpstr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+703 lines, -825 lines) Patch
M cc/BUILD.gn View 4 chunks +12 lines, -16 lines 0 comments Download
M cc/cc.gyp View 4 chunks +12 lines, -16 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D cc/resources/eviction_tile_priority_queue.h View 1 chunk +0 lines, -59 lines 0 comments Download
D cc/resources/eviction_tile_priority_queue.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D cc/resources/raster_tile_priority_queue.h View 1 chunk +0 lines, -59 lines 0 comments Download
D cc/resources/raster_tile_priority_queue.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M cc/resources/tile_manager.h View 4 chunks +103 lines, -18 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +435 lines, -0 lines 0 comments Download
M cc/resources/tile_manager_perftest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 17 chunks +130 lines, -77 lines 0 comments Download
M cc/test/fake_tile_manager_client.h View 1 chunk +1 line, -6 lines 0 comments Download
M cc/test/fake_tile_manager_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 5 chunks +1 line, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +1 line, -50 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kunihiko Sakamoto
Created Revert of cc: Change TileManager iterators to be queues.
6 years, 5 months ago (2014-07-22 02:34:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/406183002/1
6 years, 5 months ago (2014-07-22 02:36:16 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 02:44:48 UTC) #3
Message was sent while issue was closed.
Change committed as 284604

Powered by Google App Engine
This is Rietveld 408576698