Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 406163003: Cleanup model/ct-commit and use every. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Cleanup model/ct-commit and use every. -Get rid of url getter. There's no reason not to just store the url as a regular property. -Fix revision finder to not be blink specific. -Don't split the whole message just to get the first line. -Add tests. I had added tests in my last commit, but it got lost somehow. -Use every for computing revision ranges. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178622

Patch Set 1 #

Patch Set 2 : merge to ToT #

Total comments: 1

Patch Set 3 : address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -17 lines) Patch
M Tools/GardeningServer/model/ct-commit.html View 1 chunk +16 lines, -13 lines 0 comments Download
A Tools/GardeningServer/model/ct-commit-tests.html View 1 chunk +58 lines, -0 lines 0 comments Download
M Tools/GardeningServer/run-unittests.html View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-commit-list.html View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 5 months ago (2014-07-22 02:34:44 UTC) #1
esprehn
lgtm https://codereview.chromium.org/406163003/diff/20001/Tools/GardeningServer/ui/ct-commit-list.html File Tools/GardeningServer/ui/ct-commit-list.html (right): https://codereview.chromium.org/406163003/diff/20001/Tools/GardeningServer/ui/ct-commit-list.html#newcode37 Tools/GardeningServer/ui/ct-commit-list.html:37: this._revisions = Number.range(this.first, this.last).every(1); 1 is the default, ...
6 years, 5 months ago (2014-07-22 02:49:45 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 5 months ago (2014-07-22 05:20:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/406163003/40001
6 years, 5 months ago (2014-07-22 05:20:49 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 05:21:20 UTC) #5
Message was sent while issue was closed.
Change committed as 178622

Powered by Google App Engine
This is Rietveld 408576698