Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: Tools/GardeningServer/model/ct-commit.html

Issue 406163003: Cleanup model/ct-commit and use every. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/model/ct-commit.html
diff --git a/Tools/GardeningServer/model/ct-commit.html b/Tools/GardeningServer/model/ct-commit.html
index 71806e51898468c2b25cea9e8461879322e0b5b2..df6e968164419be8dbfff0d62dcc77291b7905e8 100644
--- a/Tools/GardeningServer/model/ct-commit.html
+++ b/Tools/GardeningServer/model/ct-commit.html
@@ -9,26 +9,29 @@ function CTCommit(author, message, baseUrl) {
this.author = author;
this.message = message;
this.revision = this._findRevision();
- // FIXME: This is a needlessly expensive way to grab the first line.
- this.summary = this.message.split('\n')[0];
- this._baseUrl = baseUrl;
+ this.summary = this._findSummary();
+ this.url = this._url(baseUrl);
}
-Object.defineProperty(CTCommit.prototype, "url", {
- get: function url() {
- return this._baseUrl + '?' + Object.toQueryString({
- view: 'rev',
- revision: this.revision,
- });
- },
-});
+CTCommit.prototype._url = function(baseUrl) {
+ return baseUrl + '?' + Object.toQueryString({
+ view: 'rev',
+ revision: this.revision,
+ });
+}
CTCommit.prototype._findRevision = function() {
- // FIXME: Make this regexp more general.
- var regexp = /git-svn-id: svn:\/\/svn.chromium.org\/blink\/trunk@(\d+)/;
+ // FIXME: This needs to be updated post git-migration to
+ // use the new commit numbers (ideally not git hashes!).
+ var regexp = /git-svn-id:[^@]*@(\d+)/;
var match = regexp.exec(this.message);
if (match)
return parseInt(match[1], 10);
return null;
}
+
+CTCommit.prototype._findSummary = function() {
+ var index = this.message.indexOf('\n');
+ return this.message.substring(0, index);
+}
</script>
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698