Remove setting for disabling cc touch hit testing.

Remove setting for disabling cc touch hit testing.

Compositor touch hit testing was re-enabled on Android webview back in February
(https://codereview.chromium.org/183943002) and we haven't had any complaints
since. It's probably safe to remove the flag and related code now.

This is part 2 of 2, depends on Chromium CL:
https://codereview.chromium.org/399953004

BUG=304518
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178806

[Zeeshan Qureshi, 2014-07-21 19:02:18]

aelias@chromium.org: Please review changes in
Source/web

rbyers@chromium.org: Please review changes in
Source/core

[Zeeshan Qureshi, 2014-07-21 19:03:03]

jamesr@chromium.org: Please review changes in 
Public/web

[Rick Byers, 2014-07-21 19:24:46]

lgtm (all files - still need OWNER outside core)

[jamesr, 2014-07-21 19:31:28]

/web/ lgtm

https://codereview.chromium.org/406053002/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/406053002/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:106: return
RuntimeEnabledFeatures::touchEnabled() && contentRenderer &&
contentRenderer->usesCompositing();
i think we can delete this function completely and just check touchEnabled() at
the callsites.  The code that checks the return vale of this function only runs
when compositing is enabled (which is very nearly all the time these days)

[Zeeshan Qureshi, 2014-07-21 19:52:50]

https://codereview.chromium.org/406053002/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/406053002/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:106: return
RuntimeEnabledFeatures::touchEnabled() && contentRenderer &&
contentRenderer->usesCompositing();
On 2014/07/21 19:31:28, jamesr wrote:
> i think we can delete this function completely and just check touchEnabled()
at
> the callsites.  The code that checks the return vale of this function only
runs
> when compositing is enabled (which is very nearly all the time these days)

Thanks, I'll double check with Rick and update.

[Rick Byers, 2014-07-21 20:04:07]

On 2014/07/21 19:52:50, Zeeshan Qureshi wrote:
>
https://codereview.chromium.org/406053002/diff/1/Source/core/page/scrolling/S...
> File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):
> 
>
https://codereview.chromium.org/406053002/diff/1/Source/core/page/scrolling/S...
> Source/core/page/scrolling/ScrollingCoordinator.cpp:106: return
> RuntimeEnabledFeatures::touchEnabled() && contentRenderer &&
> contentRenderer->usesCompositing();
> On 2014/07/21 19:31:28, jamesr wrote:
> > i think we can delete this function completely and just check touchEnabled()
> at
> > the callsites.  The code that checks the return vale of this function only
> runs
> > when compositing is enabled (which is very nearly all the time these days)
> 
> Thanks, I'll double check with Rick and update.

Yep, with the changes shawnsingh@ made a little while ago the checks for
compositing here have become redundant.  I agree this function should be removed
- thanks James.  Feel free to do that now or in a separate CL if you like.

[Zeeshan Qureshi, 2014-07-22 02:36:16]

> Yep, with the changes shawnsingh@ made a little while ago the checks for
> compositing here have become redundant.  I agree this function should be
removed
> - thanks James.  Feel free to do that now or in a separate CL if you like.

Updated.

[Zeeshan Qureshi, 2014-07-23 19:36:51]

The CQ bit was checked by zeeshanq@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:37:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/406053002/20001

[Zeeshan Qureshi, 2014-07-23 21:32:29]

The CQ bit was unchecked by zeeshanq@chromium.org

[Zeeshan Qureshi, 2014-07-23 21:32:33]

The CQ bit was checked by zeeshanq@chromium.org

[commit-bot: I haz the power, 2014-07-23 21:32:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/406053002/20001

[commit-bot: I haz the power, 2014-07-24 04:28:45]

Change committed as 178806