Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 399953004: Remove flag to disable cc touch hit testing. (Closed)

Created:
6 years, 5 months ago by Zeeshan Qureshi
Modified:
6 years, 5 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, jam, nasko+codewatch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove flag to disable cc touch hit testing. Compositor touch hit testing was re-enabled on Android webview back in February (https://codereview.chromium.org/183943002) and we haven't had any complaints since. It's probably safe to remove the flag and related code now. This is part 1 of 2, will be followed by: https://codereview.chromium.org/406053002 BUG=304518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M cc/base/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
Zeeshan Qureshi
Rick, can you have a quick look? Will add OWNERS after.
6 years, 5 months ago (2014-07-18 19:28:40 UTC) #1
Rick Byers
LGTM Once this lands, you'll remove the WebKit side too, right? Probably worth mentioning in ...
6 years, 5 months ago (2014-07-21 18:44:31 UTC) #2
Zeeshan Qureshi
On 2014/07/21 18:44:31, Rick Byers wrote: > LGTM > > Once this lands, you'll remove ...
6 years, 5 months ago (2014-07-21 18:45:22 UTC) #3
Zeeshan Qureshi
vollick@chromium.org: Please review changes in cc/ kenrb@chromium.org: Please review changes in content/public/common/common_param_traits_macros.h jochen@chromium.org: Please review ...
6 years, 5 months ago (2014-07-21 19:07:32 UTC) #4
Ian Vollick
On 2014/07/21 19:07:32, Zeeshan Qureshi wrote: > mailto:vollick@chromium.org: Please review changes in > cc/ > ...
6 years, 5 months ago (2014-07-22 15:28:46 UTC) #5
kenrb
ipc lgtm
6 years, 5 months ago (2014-07-22 16:20:21 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 09:13:31 UTC) #7
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 5 months ago (2014-07-23 13:56:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/399953004/1
6 years, 5 months ago (2014-07-23 13:58:54 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 15:52:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 16:14:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173816)
6 years, 5 months ago (2014-07-23 16:14:16 UTC) #12
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 5 months ago (2014-07-23 16:53:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/399953004/1
6 years, 5 months ago (2014-07-23 16:54:49 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 17:05:59 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 17:26:50 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173862)
6 years, 5 months ago (2014-07-23 17:26:51 UTC) #17
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 5 months ago (2014-07-23 19:24:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/399953004/1
6 years, 5 months ago (2014-07-23 19:25:58 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:28:21 UTC) #20
Message was sent while issue was closed.
Change committed as 285013

Powered by Google App Engine
This is Rietveld 408576698