sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart - Issue 40583002: Incorporates feedback by Nicolas for UTF-8 bytes based scanner CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart

Issue 40583002: Incorporates feedback by Nicolas for UTF-8 bytes based scanner CL (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart ('k') | sdk/lib/_internal/compiler/implementation/scanner/token.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart

diff --git a/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart b/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart

index 2dd92f9115fe66b8491a6ebd4f9f5fb1cf43967c..f0f11e0257c186ad1f8984959deb96908a0a6f5d 100644

--- a/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart

+++ b/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart

@@ -42,14 +42,13 @@ class StringScanner extends ArrayBasedScanner {

void handleUnicode(int startScanOffset) { }

Token firstToken() => tokens.next;

Token previousToken() => tail;

void appendSubstringToken(PrecedenceInfo info, int start,

bool asciiOnly, [int extraOffset = 0]) {

tail.next = new StringToken.fromSubstring(info, string, start,

- scanOffset + extraOffset, tokenStart, true);

+ scanOffset + extraOffset, tokenStart, canonicalize: true);

tail = tail.next;

}