sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart - Issue 40583002: Incorporates feedback by Nicolas for UTF-8 bytes based scanner CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart

Issue 40583002: Incorporates feedback by Nicolas for UTF-8 bytes based scanner CL (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/scanner.dart ('k') | sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart b/sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart

index 869e20e369c7e37ac00ea2d81cd225c5efb2c282..0fa7c5709310f2e758ae1880814820aec319c568 100644

--- a/sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart

@@ -40,8 +40,8 @@ class ScannerTask extends CompilerTask {

* Returns the tokens for the [source].

* The [StringScanner] implementation works on strings that end with a '0'

- * value ('\x00'). If [source] does not with '0', the string is copied before

- * scanning.

+ * value ('\x00'). If [source] does not end with '0', the string is copied

+ * before scanning.

Token tokenize(String source) {

return measure(() {