Issue 405803006: Unflag symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405803006: Unflag symbols (Closed)

Created:
6 years, 5 months ago by rossberg

Modified:
6 years, 4 months ago

Reviewers:
arv (Not doing code reviews), Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Unflag symbols R=yangguo@chromium.org BUG=

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -44 lines)			Patch
M	src/bootstrapper.cc	View	5 chunks	+10 lines, -13 lines	0 comments	Download
M	src/flag-definitions.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/debug-script.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/es6/mirror-symbols.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/es6/regress/regress-crbug-346141.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/es6/symbols.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/es7/object-observe.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/harmony/iteration-semantics.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/harmony/private.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/mjsunit/harmony/proxies-symbols.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/set-prototype-of.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/proto-accessor.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/regress/regress-crbug-350864.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2014/07/21 16:37:03, rossberg wrote: I think you also need to update BUILD.gn. Other than ...

6 years, 5 months ago (2014-07-22 16:33:34 UTC) #2

Yang

6 years, 4 months ago (2014-08-19 08:05:57 UTC) #4

On 2014/07/22 16:55:51, arv wrote:
> Hot!
> 
> LGTM

Already done here: https://codereview.chromium.org/421313004