Make old cursor warp mode ozone only

Make old cursor warp mode ozone only

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285167

[oshima, 2014-07-22 17:43:45]

https://codereview.chromium.org/405483005/diff/60001/ash/display/mouse_cursor...
File ash/display/mouse_cursor_event_filter_unittest.cc (right):

https://codereview.chromium.org/405483005/diff/60001/ash/display/mouse_cursor...
ash/display/mouse_cursor_event_filter_unittest.cc:220:
TEST_F(MouseCursorEventFilterTest, DoNotWarpTwice) {
This test is currently failing without my change.

[dnicoara, 2014-07-22 17:50:35]

lgtm

[oshima, 2014-07-22 21:04:09]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-07-22 21:07:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/405483005/60001

[commit-bot: I haz the power, 2014-07-22 22:03:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-22 22:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 22:50:10]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[spang, 2014-07-23 19:07:24]

On 2014/07/22 22:50:10, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_gn_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

To fix the GN trybot, add this to ash/BUILD.gn under component("ash")

  if (!use_ozone) {
    sources -= [
      "display/mouse_cursor_event_filter_ozone.cc",
    ]
  }

[oshima, 2014-07-23 19:50:59]

On 2014/07/23 19:07:24, spang wrote:
> On 2014/07/22 22:50:10, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_gn_rel on tryserver.chromium
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
> 
> To fix the GN trybot, add this to ash/BUILD.gn under component("ash")
> 
>   if (!use_ozone) {
>     sources -= [
>       "display/mouse_cursor_event_filter_ozone.cc",
>     ]
>   }

Isn't it better to have a global rule to exclude _ozone files in regular linux
builds, like _chromeos, _win ?

[spang, 2014-07-23 20:56:36]

On 2014/07/23 19:50:59, oshima wrote:
> On 2014/07/23 19:07:24, spang wrote:
> > On 2014/07/22 22:50:10, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   linux_chromium_gn_rel on tryserver.chromium
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
> > 
> > To fix the GN trybot, add this to ash/BUILD.gn under component("ash")
> > 
> >   if (!use_ozone) {
> >     sources -= [
> >       "display/mouse_cursor_event_filter_ozone.cc",
> >     ]
> >   }
> 
> Isn't it better to have a global rule to exclude _ozone files in regular linux
> builds, like _chromeos, _win ?

The GN team has decided not to support these pattern-based rules for features.
Recent PSA says:

> Another gotcha: GN has fewer automatic filename filters (on purpose).
> Platform ones (*_win.cc) should be the same, but feature/toolkit ones
> (*_ozone.cc) don't exist. You may need to add exclusions if you see
> errors from the GN trybot.

this is from
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/CgaS6oAgoho

[oshima, 2014-07-24 06:52:27]

On 2014/07/23 20:56:36, spang wrote:
> On 2014/07/23 19:50:59, oshima wrote:
> > On 2014/07/23 19:07:24, spang wrote:
> > > On 2014/07/22 22:50:10, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders:
> > > >   linux_chromium_gn_rel on tryserver.chromium
> > > >
> > >
> >
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
> > > 
> > > To fix the GN trybot, add this to ash/BUILD.gn under component("ash")
> > > 
> > >   if (!use_ozone) {
> > >     sources -= [
> > >       "display/mouse_cursor_event_filter_ozone.cc",
> > >     ]
> > >   }
> > 
> > Isn't it better to have a global rule to exclude _ozone files in regular
linux
> > builds, like _chromeos, _win ?
> 
> The GN team has decided not to support these pattern-based rules for features.
> Recent PSA says:
> 
> > Another gotcha: GN has fewer automatic filename filters (on purpose).
> > Platform ones (*_win.cc) should be the same, but feature/toolkit ones
> > (*_ozone.cc) don't exist. You may need to add exclusions if you see
> > errors from the GN trybot.
> 
> this is from
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/CgaS6oAgoho

got it. thanks.

[oshima, 2014-07-24 06:52:33]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-07-24 06:54:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/405483005/80001

[commit-bot: I haz the power, 2014-07-24 10:27:19]

Change committed as 285167