Apps&Extensions for supervised users: Allow the custodian to remotely uninstall extensions.

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 03d1faffd0c87fa6f704a3bb2eab9fe93431e077..6242bba481cdf52008b61673c3b6c262c6b7897b 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -699,7 +699,8 @@ bool ExtensionService::UninstallExtension(
   bool external_uninstall =
       (reason == UNINSTALL_REASON_INTERNAL_MANAGEMENT) ||
       (reason == UNINSTALL_REASON_ORPHANED_EXTERNAL_EXTENSION) ||
-      (reason == UNINSTALL_REASON_ORPHANED_SHARED_MODULE);
+      (reason == UNINSTALL_REASON_ORPHANED_SHARED_MODULE) ||
+      (reason == UNINSTALL_REASON_SYNC_BY_CUSTODIAN);

[not at google - send to devlin, 2014/07/18 14:45:08]

Thanks for updating the other call sites.

With that in mind why do you need to add UNINSTALL_REASON_SYNC_BY_CUSTODIAN at
all, can't this check be just "extension->was_installed_by_custodian()"?

[not at google - send to devlin, 2014/07/21 16:48:23]

I guess I mean 2 things:
- you could not even trigger the uninstall in the first place if
was_installed_by_custodian is true. but maybe this is already the case.
- instead of doing (reason == UNINSTALL_REASON_SYNC_BY_CUSTODIAN) you could do
(reason == UNINSTALL_REASON_SYNC && was_installed_by_custodian).

[Marc Treib, 2014/07/22 09:30:07]

Ah, right, that'll work, and not require changes to all call sites. Thanks,
done!

   if (!external_uninstall &&
       !system_->management_policy()->UserMayModifySettings(
         extension.get(), error)) {