Apps&Extensions for supervised users: Allow the custodian to remotely uninstall extensions.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 681 matching lines @@
   // managed extensions.
   // Shared modules being uninstalled will also set |external_uninstall| to true
   // so that we can guarantee users don't uninstall a shared module.
   // (crbug.com/273300)
   // TODO(rdevlin.cronin): This is probably not right. We should do something
   // else, like include an enum IS_INTERNAL_UNINSTALL or IS_USER_UNINSTALL so
   // we don't do this.
   bool external_uninstall =
       (reason == UNINSTALL_REASON_INTERNAL_MANAGEMENT) ||
       (reason == UNINSTALL_REASON_ORPHANED_EXTERNAL_EXTENSION) ||
-      (reason == UNINSTALL_REASON_ORPHANED_SHARED_MODULE);
+      (reason == UNINSTALL_REASON_ORPHANED_SHARED_MODULE) ||
+      (reason == UNINSTALL_REASON_SYNC_BY_CUSTODIAN);

[not at google - send to devlin, 2014/07/18 14:45:08]

Thanks for updating the other call sites.

With that in mind why do you need to add UNINSTALL_REASON_SYNC_BY_CUSTODIAN at
all, can't this check be just "extension->was_installed_by_custodian()"?

[not at google - send to devlin, 2014/07/21 16:48:23]

I guess I mean 2 things:
- you could not even trigger the uninstall in the first place if
was_installed_by_custodian is true. but maybe this is already the case.
- instead of doing (reason == UNINSTALL_REASON_SYNC_BY_CUSTODIAN) you could do
(reason == UNINSTALL_REASON_SYNC && was_installed_by_custodian).

[Marc Treib, 2014/07/22 09:30:07]

Ah, right, that'll work, and not require changes to all call sites. Thanks,
done!

   if (!external_uninstall &&
       !system_->management_policy()->UserMayModifySettings(
         extension.get(), error)) {
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_EXTENSION_UNINSTALL_NOT_ALLOWED,
         content::Source<Profile>(profile_),
         content::Details<const Extension>(extension.get()));
     return false;
   }
 
@@ skipping 1617 matching lines @@
 }
 
 void ExtensionService::OnProfileDestructionStarted() {
   ExtensionIdSet ids_to_unload = registry_->enabled_extensions().GetIDs();
   for (ExtensionIdSet::iterator it = ids_to_unload.begin();
        it != ids_to_unload.end();
        ++it) {
     UnloadExtension(*it, UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN);
   }
 }