Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 405383003: Add missing id/name check over img-based RadioNodeLists. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add missing id/name check over img-based RadioNodeLists. For named lookups on forms, the spec tells us (step 2) http://www.whatwg.org/specs/web-apps/current-work/#dom-form-nameditem that the RadioNodeList returned for the <img> only case should be constrained to only those matching the given name/id. R= BUG=387312 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M LayoutTests/fast/forms/form-radio-img-node-list.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-radio-img-node-list-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/RadioNodeList.cpp View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look. I completely failed to grasp how these collections are filtered; my ...
6 years, 5 months ago (2014-07-22 14:00:53 UTC) #1
tkent
lgtm
6 years, 5 months ago (2014-07-22 23:15:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/405383003/1
6 years, 5 months ago (2014-07-22 23:17:43 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 00:40:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 01:01:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/26845)
6 years, 5 months ago (2014-07-23 01:01:06 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-23 01:01:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/405383003/1
6 years, 5 months ago (2014-07-23 01:02:37 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 02:23:17 UTC) #9
Message was sent while issue was closed.
Change committed as 178721

Powered by Google App Engine
This is Rietveld 408576698