Source/core/html/RadioNodeList.h - Issue 405383003: Add missing id/name check over img-based RadioNodeLists.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/RadioNodeList.h

Issue 405383003: Add missing id/name check over img-based RadioNodeLists. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 Motorola Mobility, Inc. All rights reserved.	2 * Copyright (c) 2012 Motorola Mobility, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 virtual ~RadioNodeList();	43 virtual ~RadioNodeList();

44	44

45 String value() const;	45 String value() const;

46 void setValue(const String&);	46 void setValue(const String&);

47	47

48 private:	48 private:

49 RadioNodeList(ContainerNode&, const AtomicString& name, CollectionType);	49 RadioNodeList(ContainerNode&, const AtomicString& name, CollectionType);

50	50

51 bool checkElementMatchesRadioNodeListFilter(const Element&) const;	51 bool checkElementMatchesRadioNodeListFilter(const Element&) const;

52	52

	53 bool matchesByIdOrName(const Element&) const;

	54

53 virtual bool elementMatches(const Element&) const OVERRIDE;	55 virtual bool elementMatches(const Element&) const OVERRIDE;

54	56

55 AtomicString m_name;	57 AtomicString m_name;

56 const bool m_onlyMatchImgElements;	58 const bool m_onlyMatchImgElements;

57 };	59 };

58	60

59 } // namespace	61 } // namespace

60	62

61 #endif	63 #endif

62

OLD	NEW

« no previous file with comments | « LayoutTests/fast/forms/form-radio-img-node-list-expected.txt ('k') | Source/core/html/RadioNodeList.cpp » ('j') | no next file with comments »