Issue 405353003: Merge 278990 "Put back sign in / sign out / new user handling in..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405353003: Merge 278990 "Put back sign in / sign out / new user handling in..." (Closed)

Created:
6 years, 5 months ago by benwells

Modified:
6 years, 5 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge 278990 "Put back sign in / sign out / new user handling in..." > Put back sign in / sign out / new user handling in the App Launcher. > > This handling updates the menu and does other things with the available > users changes. It was erroneously removed with the change to allow > signed out users to use the app launcher. > > Some unnecessary testing code is also removed. > > BUG=386885 > > Review URL: https://codereview.chromium.org/347993002 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284630

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -19 lines)			Patch
M	chrome/browser/ui/app_list/app_list_controller_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_service_views_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/app_list_view_delegate.h	View	4 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/app_list_view_delegate.cc	View	4 chunks	+49 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/test/chrome_app_list_test_support.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/test/chrome_app_list_test_support.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

benwells

6 years, 5 months ago (2014-07-22 05:01:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r284630 (tree was closed).

Expand Messages | Collapse Messages