Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 347993002: Put back sign in / sign out / new user handling in the App Launcher. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Put back sign in / sign out / new user handling in the App Launcher. This handling updates the menu and does other things with the available users changes. It was erroneously removed with the change to allow signed out users to use the app launcher. Some unnecessary testing code is also removed. BUG=386885 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278990

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -19 lines) Patch
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_views_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 4 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 4 chunks +49 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/chrome_app_list_test_support.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/test/chrome_app_list_test_support.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
benwells
6 years, 6 months ago (2014-06-20 07:46:03 UTC) #1
tapted
lgtm https://codereview.chromium.org/347993002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://codereview.chromium.org/347993002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode112 chrome/browser/ui/app_list/app_list_view_delegate.cc:112: SigninManagerFactory::GetInstance()->AddObserver(this); nit: Maybe we need a comment here ...
6 years, 6 months ago (2014-06-20 07:59:00 UTC) #2
benwells
https://codereview.chromium.org/347993002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://codereview.chromium.org/347993002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode112 chrome/browser/ui/app_list/app_list_view_delegate.cc:112: SigninManagerFactory::GetInstance()->AddObserver(this); On 2014/06/20 07:58:59, tapted wrote: > nit: Maybe ...
6 years, 6 months ago (2014-06-20 08:57:12 UTC) #3
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-20 08:57:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/347993002/20001
6 years, 6 months ago (2014-06-20 08:58:52 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 14:00:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 14:48:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19890)
6 years, 6 months ago (2014-06-20 14:48:41 UTC) #8
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-21 23:53:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/347993002/20001
6 years, 6 months ago (2014-06-21 23:55:01 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-22 01:10:20 UTC) #11
Message was sent while issue was closed.
Change committed as 278990

Powered by Google App Engine
This is Rietveld 408576698