Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: tools/telemetry/telemetry/results/page_test_results.py

Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_test_results.py
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index 38b1a668aa2127575a127845fa812d7e8ada4bc4..bd76ce422b07051e7415f03638c579b3d2dd148a 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -56,15 +56,15 @@ class PageTestResults(object):
pass
def AddValue(self, value):
- self.ValidateValue(value)
+ self._ValidateValue(value)
self._all_page_specific_values.append(value)
def AddSummaryValue(self, value):
assert value.page is None
- self.ValidateValue(value)
+ self._ValidateValue(value)
self._all_summary_values.append(value)
- def ValidateValue(self, value):
+ def _ValidateValue(self, value):
assert isinstance(value, value_module.Value)
if value.name not in self._representative_value_for_each_value_name:
self._representative_value_for_each_value_name[value.name] = value
« no previous file with comments | « tools/telemetry/telemetry/results/page_measurement_results.py ('k') | tools/telemetry/telemetry/value/failure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698