Android: fixes for JNI with javap for java7.

Android: fixes for JNI with javap for java7.

The output of javap from java7 has changed, most notably:
public boolean add(java.lang.Object);
 Signature: (Ljava/lang/Object;)Z
became:
public boolean add(E);
  Signature: (Ljava/lang/Object;)Z

Rather than relying on parsing the parameters, use the signature field directly.

BUG=
TEST=base/android/jni_generator_tests.py

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231031

[bulach, 2013-10-24 16:17:01]

ptal

[joth, 2013-10-24 19:18:13]

lgtm, +torne FYI.

https://codereview.chromium.org/40523002/diff/30001/base/android/jni_generato...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/40523002/diff/30001/base/android/jni_generato...
base/android/jni_generator/jni_generator.py:148: return None
is missing the "Signature:" prefix an allowable situation?
If not seems better to just have the index() method throw Value exception so we
know about it a build rather than runtime (e.g. if the tools change again).

[rmcilroy, 2013-10-24 21:13:22]

lgtm

+1 to Joth's suggestion.

[bulach, 2013-10-25 08:45:49]

thanks both! comment addressed, CQing..

https://codereview.chromium.org/40523002/diff/30001/base/android/jni_generato...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/40523002/diff/30001/base/android/jni_generato...
base/android/jni_generator/jni_generator.py:148: return None
On 2013/10/24 19:18:13, joth wrote:
> is missing the "Signature:" prefix an allowable situation?
> If not seems better to just have the index() method throw Value exception so
we
> know about it a build rather than runtime (e.g. if the tools change again).

good point!
turns out there's a "-s" parameter to javap to force printing the signature,
available both for javap6 and 7.
using that option instead (had to adjust some tests but didn't change the
semantics)

[commit-bot: I haz the power, 2013-10-25 08:48:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/40523002/110001

[commit-bot: I haz the power, 2013-10-25 14:48:45]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-25 14:52:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/40523002/110001

[commit-bot: I haz the power, 2013-10-25 16:27:05]

Change committed as 231031