Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 405163002: Add EmbedRoot to ViewManagerService. (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add EmbedRoot to ViewManagerService. This means if you have an existing ViewManager connection you can just use that to ask the WM to embed a new node for you. Also fix the issue where only one call to EmbedRoot() could be made to the init service prior to the window tree host being ready. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284952

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -63 lines) Patch
M mojo/examples/aura_demo/view_manager_init.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/demo_launcher/demo_launcher.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/window_manager_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.cc View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 4 chunks +28 lines, -14 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ben Goodger (Google)
6 years, 5 months ago (2014-07-21 18:41:03 UTC) #1
sky
LGTM if you rename Root to something else. https://codereview.chromium.org/405163002/diff/20001/mojo/services/public/interfaces/view_manager/view_manager.mojom File mojo/services/public/interfaces/view_manager/view_manager.mojom (right): https://codereview.chromium.org/405163002/diff/20001/mojo/services/public/interfaces/view_manager/view_manager.mojom#newcode143 mojo/services/public/interfaces/view_manager/view_manager.mojom:143: EmbedRoot(string ...
6 years, 5 months ago (2014-07-21 19:26:53 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 5 months ago (2014-07-22 05:42:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/405163002/60001
6 years, 5 months ago (2014-07-22 05:43:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 08:41:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 09:11:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41473)
6 years, 5 months ago (2014-07-22 09:11:02 UTC) #7
Ben Goodger (Google)
6 years, 5 months ago (2014-07-23 16:45:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r284952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698