Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 405163002: Add EmbedRoot to ViewManagerService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 5edd9cee24893febf080314fce57ad195253be96..a5d27391f76974d2515911e9a3c62fc101aae668 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -33,7 +33,7 @@ interface ViewManagerInitService {
// application embedded at the service root Node. This application is
// typically referred to as the "window manager", and will have a specific
// definition of where within its Node hierarchy to embed an unparented URL.
- EmbedRoot(string url) => (bool success);
+ Embed(string url) => (bool success);
};
// Nodes and Views are identified by a uint32. The upper 16 bits are the
@@ -134,6 +134,10 @@ interface ViewManagerService {
// current connection. The current connection is told this by way of
// OnNodeDeleted().
//
+ // If |node_id| is 0, the View Manager delegates determination of what node to
+ // embed |url| at to the app embedded at the service root node (i.e. the
+ // window manager).
+ //
// This advances the server change id.
Embed(string url, uint32 node_id) => (bool success);
@@ -207,7 +211,7 @@ interface ViewManagerClient {
// once support for derived FIFOs is landed.
// Requests the window manager create a "top level" node embedding |url|.
- EmbedRoot(string url);
+ Embed(string url);
// Requests the view manager dispatch the event targeted at |view|.
DispatchOnViewInputEvent(uint32 view, mojo.Event event);
« no previous file with comments | « mojo/services/public/cpp/view_manager/window_manager_delegate.h ('k') | mojo/services/view_manager/root_node_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698