Issue 405143003: Merge 279817 "Don't crash on splice frame failure with bad content."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405143003: Merge 279817 "Don't crash on splice frame failure with bad content." (Closed)

Created:
6 years, 5 months ago by DaleCurtis

Modified:
6 years, 5 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge 279817 "Don't crash on splice frame failure with bad content." > Don't crash on splice frame failure with bad content. > > Turns out this isn't something we can CHECK() if the content has > "bad" timestamps. "bad" in this case being either a bad file or > a bug in the timestamping code. I haven't figured out which yet, > but in either case we shouldn't crash. > > BUG=388068 > TEST=new unittest > > Review URL: https://codereview.chromium.org/339433006 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284452

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -8 lines)			Patch
M	media/base/audio_splicer.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	media/base/audio_splicer.cc	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	media/base/audio_splicer_unittest.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r284452.

Expand Messages | Collapse Messages