Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 339433006: Don't crash on splice frame failure with bad content. (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Don't crash on splice frame failure with bad content. Turns out this isn't something we can CHECK() if the content has "bad" timestamps. "bad" in this case being either a bad file or a bug in the timestamping code. I haven't figured out which yet, but in either case we shouldn't crash. BUG=388068 TEST=new unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279817

Patch Set 1 : Cleanup. #

Total comments: 2

Patch Set 2 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M media/base/audio_splicer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/audio_splicer.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M media/base/audio_splicer_unittest.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
Crashing is just no fun.
6 years, 6 months ago (2014-06-24 01:57:49 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/339433006/diff/20001/media/base/audio_splicer_unittest.cc File media/base/audio_splicer_unittest.cc (right): https://codereview.chromium.org/339433006/diff/20001/media/base/audio_splicer_unittest.cc#newcode686 media/base/audio_splicer_unittest.cc:686: // between whats in the pre splice and ...
6 years, 6 months ago (2014-06-25 16:27:55 UTC) #2
DaleCurtis
Thanks for review! https://codereview.chromium.org/339433006/diff/20001/media/base/audio_splicer_unittest.cc File media/base/audio_splicer_unittest.cc (right): https://codereview.chromium.org/339433006/diff/20001/media/base/audio_splicer_unittest.cc#newcode686 media/base/audio_splicer_unittest.cc:686: // between whats in the pre ...
6 years, 6 months ago (2014-06-25 18:30:10 UTC) #3
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-06-25 18:30:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/339433006/40001
6 years, 6 months ago (2014-06-25 18:33:45 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 21:15:12 UTC) #6
Message was sent while issue was closed.
Change committed as 279817

Powered by Google App Engine
This is Rietveld 408576698