Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Issue 405123002: clang/win: Fix a Wenum-compare warning and a few Wwritable-strings warnings. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix a Wenum-compare warning and a few Wwritable-strings warnings. BUG=82385 R=rnk@chromium.org TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284447

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M base/time/time_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/win/lib/process_info.h View 1 chunk +0 lines, -7 lines 0 comments Download
M rlz/win/lib/process_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
6 years, 5 months ago (2014-07-21 16:53:53 UTC) #1
Reid Kleckner
lgtm
6 years, 5 months ago (2014-07-21 16:56:34 UTC) #2
Nico
tbr=jochen for the content change
6 years, 5 months ago (2014-07-21 17:02:55 UTC) #3
Nico
6 years, 5 months ago (2014-07-21 17:03:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r284447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698