Issue 40503002: Allow users to build on top of, instead of beneath, SkRefCnt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40503002: Allow users to build on top of, instead of beneath, SkRefCnt. (Closed)

Created:
7 years, 2 months ago by bungeman-skia

Modified:
7 years, 1 month ago

Reviewers:
junov1, Justin Novosad, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Allow users to build on top of, instead of beneath, SkRefCnt. Alternative to r11811. The Chromium half of this can be seen at https://codereview.chromium.org/40973002/ . R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11967

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -40 lines)			Patch
	M	include/core/SkRefCnt.h	View		6 chunks	+14 lines, -34 lines	0 comments	Download
	M	src/core/SkRefCnt.cpp	View		1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

bungeman-skia

After some thought (and since Chromium r230161 got rolled out with r230203) I think this ...

7 years, 2 months ago (2013-10-24 16:02:00 UTC) #1

Justin Novosad

On 2013/10/24 16:02:00, bungeman1 wrote: > After some thought (and since Chromium r230161 got rolled ...

7 years, 2 months ago (2013-10-24 18:47:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r11967.