Issue 405023003: Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405023003: Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
jvanverth1, bsalomon

CC:
reviews_skia.org, egdaniel

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… (https://codereview.chromium.org/376703009/) Reason for revert: Trying to unblock roll wedged on 64 bit intrinsic call on XP Original issue's description: > Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are deleted. > > Also, rename GrCacheable::getGenerationID() to getInstanceID() since it doesn't behave like other "generation" IDs. > > Committed: https://skia.googlesource.com/skia/+/91bdbcdbbdf5cdf0fdb4518a0d30206c964cfdf6 TBR=jvanverth@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/249171e7d29b5559f3eefe9dbd437030bfad3fda

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -39 lines)			Patch
M	include/gpu/GrCacheable.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/gpu/GrBitmapTextContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrBitmapTextContext.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrCacheable.cpp	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	15 chunks	+35 lines, -20 lines	0 comments	Download

Total messages: 1 (0 generated)

robertphillips

6 years, 5 months ago (2014-07-20 16:20:41 UTC) #1

Created Revert of Use the GrCacheable ID to eliminate the need for notifications
to GrGpuGL when textures and RTs are…