Source/devtools/front_end/timeline/TracingTimelineUIUtils.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

diff --git a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

index 040e7fb18bbdafc1782ac052a58d59bfd03432b5..cf2b262cda6afcce5395f308a3602e3d4ae6b375 100644

--- a/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

+++ b/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

@@ -457,7 +457,7 @@ WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent = function(eve

return null;

// FIXME(62725): stack trace line/column numbers are one-based.

- return linkifier.linkifyLocationByScriptId(target, scriptId, url, lineNumber - 1, (columnNumber ||1) - 1, "timeline-details");

+ return linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber - 1, (columnNumber ||1) - 1, "timeline-details");

}

/**

« Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js ('K') | « Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js ('k') | no next file » | no next file with comments »