Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/sdk/Linkifier.js ('K') | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('j') | Source/devtools/front_end/timeline/TracingTimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

diff --git a/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js b/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

index 3841dc342d07f5d4e3473f12cf380366fde5dfe3..f9a8e41e9efd53bedb91c9a2a7424e7bde8cf75b 100644

--- a/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

+++ b/Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

@@ -410,7 +410,7 @@ WebInspector.TimelineUIUtilsImpl.buildDetailsNode = function(record, linkifier)

// FIXME(62725): stack trace line/column numbers are one-based.

columnNumber = columnNumber ? columnNumber - 1 : 0;

- return linkifier.linkifyLocationByScriptId(record.target(), scriptId, url, lineNumber - 1, columnNumber, "timeline-details");

+ return linkifier.linkifyScriptLocation(record.target(), scriptId, url, lineNumber - 1, columnNumber, "timeline-details");

}

/**