Source/devtools/front_end/profiler/CPUProfileDataGrid.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/profiler/CPUProfileDataGrid.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments #2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/profiler/CPUProfileDataGrid.js

diff --git a/Source/devtools/front_end/profiler/CPUProfileDataGrid.js b/Source/devtools/front_end/profiler/CPUProfileDataGrid.js

index 9a5e2f375aaa45d00404ed756c81da7b66c0872c..7b36511046078393892f4bb3eaa5ffcff2eb3c10 100644

--- a/Source/devtools/front_end/profiler/CPUProfileDataGrid.js

+++ b/Source/devtools/front_end/profiler/CPUProfileDataGrid.js

@@ -77,7 +77,7 @@ WebInspector.ProfileDataGridNode.prototype = {

var lineNumber = this.profileNode.lineNumber ? this.profileNode.lineNumber - 1 : 0;

var columnNumber = this.profileNode.columnNumber ? this.profileNode.columnNumber - 1 : 0;

var target = this.tree.profileView.target();

- var urlElement = this.tree.profileView._linkifier.linkifyLocationByScriptId(target, this.profileNode.scriptId, this.profileNode.url, lineNumber, columnNumber, "profile-node-file");

+ var urlElement = this.tree.profileView._linkifier.linkifyScriptLocation(target, this.profileNode.scriptId, this.profileNode.url, lineNumber, columnNumber, "profile-node-file");

urlElement.style.maxWidth = "75%";

cell.insertBefore(urlElement, cell.firstChild);

}

« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | Source/devtools/front_end/profiler/CanvasProfileView.js » ('j') | no next file with comments »