Source/devtools/front_end/network/NetworkPanel.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments #2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/elements/EventListenersSidebarPane.js ('k') | Source/devtools/front_end/profiler/CPUProfileDataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/network/NetworkPanel.js

diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js

index f493b6416344b5e9dacba433c8b7a1b849182d74..e318d6e22e27571b0b4295d350a15cf24ccd0e07 100644

--- a/Source/devtools/front_end/network/NetworkPanel.js

+++ b/Source/devtools/front_end/network/NetworkPanel.js

@@ -1044,11 +1044,10 @@ WebInspector.NetworkLogView.prototype = {

{

for (var i = 0; i < stackTrace.length; ++i) {

var stackFrame = stackTrace[i];

- var rawLocation = request.target().debuggerModel.createRawLocationByConsoleCallFrame(stackFrame);

var row = document.createElement("tr");

row.createChild("td").textContent = stackFrame.functionName || WebInspector.UIString("(anonymous function)");

row.createChild("td").textContent = " @ ";

- row.createChild("td").appendChild(this._linkifier.linkifyRawLocation(rawLocation));

+ row.createChild("td").appendChild(this._linkifier.linkifyConsoleCallFrame(request.target(), stackFrame));

framesTable.appendChild(row);

}

@@ -2774,7 +2773,7 @@ WebInspector.NetworkDataGridNode.prototype = {

case WebInspector.NetworkRequest.InitiatorType.Script:

if (!this._linkifiedInitiatorAnchor) {

- this._linkifiedInitiatorAnchor = this._linkifier.linkifyLocation(request.target(), initiator.url, initiator.lineNumber - 1, initiator.columnNumber - 1);

+ this._linkifiedInitiatorAnchor = this._linkifier.linkifyScriptLocation(request.target(), null, initiator.url, initiator.lineNumber - 1, initiator.columnNumber - 1);

this._linkifiedInitiatorAnchor.title = "";

}

cell.appendChild(this._linkifiedInitiatorAnchor);