extensions/common/permissions/permissions_data_unittest.cc - Issue 404823009: Removing the * from hosts and adding the words 'all' and 'site'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 404823009: Removing the * from hosts and adding the words 'all' and 'site'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing kalman@ comments and fixing a broken test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/permissions/permission_message_util.cc ('K') | « extensions/common/permissions/permission_message_util.cc ('k') | extensions/extensions_strings.grd » ('j') | extensions/extensions_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/permissions_data_unittest.cc

diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc

index c54e63903b86119797f3cf85f4aa71583cb0ea58..865313eefe70ca32520c2bd6f79502dc50b11e0f 100644

--- a/extensions/common/permissions/permissions_data_unittest.cc

+++ b/extensions/common/permissions/permissions_data_unittest.cc

@@ -300,7 +300,7 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {

extension->permissions_data()->GetPermissionMessageDetailsStrings();

ASSERT_EQ(1u, warnings.size());

ASSERT_EQ(1u, warnings_details.size());

- EXPECT_EQ("Read and modify your data on 5 websites",

+ EXPECT_EQ("Read and modify your data on a number of websites",

UTF16ToUTF8(warnings[0]));

EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com",

UTF16ToUTF8(warnings_details[0]));