Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 404823009: Removing the * from hosts and adding the words 'all' and 'site'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing kalman@ comments and fixing a broken test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 293
294 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) { 294 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {
295 scoped_refptr<Extension> extension; 295 scoped_refptr<Extension> extension;
296 extension = LoadManifest("permissions", "more-than-3-hosts.json"); 296 extension = LoadManifest("permissions", "more-than-3-hosts.json");
297 std::vector<base::string16> warnings = 297 std::vector<base::string16> warnings =
298 extension->permissions_data()->GetPermissionMessageStrings(); 298 extension->permissions_data()->GetPermissionMessageStrings();
299 std::vector<base::string16> warnings_details = 299 std::vector<base::string16> warnings_details =
300 extension->permissions_data()->GetPermissionMessageDetailsStrings(); 300 extension->permissions_data()->GetPermissionMessageDetailsStrings();
301 ASSERT_EQ(1u, warnings.size()); 301 ASSERT_EQ(1u, warnings.size());
302 ASSERT_EQ(1u, warnings_details.size()); 302 ASSERT_EQ(1u, warnings_details.size());
303 EXPECT_EQ("Read and modify your data on 5 websites", 303 EXPECT_EQ("Read and modify your data on a number of websites",
304 UTF16ToUTF8(warnings[0])); 304 UTF16ToUTF8(warnings[0]));
305 EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com", 305 EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com",
306 UTF16ToUTF8(warnings_details[0])); 306 UTF16ToUTF8(warnings_details[0]));
307 } 307 }
308 308
309 TEST(ExtensionPermissionsTest, GetPermissionMessages_LocationApiPermission) { 309 TEST(ExtensionPermissionsTest, GetPermissionMessages_LocationApiPermission) {
310 scoped_refptr<Extension> extension; 310 scoped_refptr<Extension> extension;
311 extension = LoadManifest("permissions", 311 extension = LoadManifest("permissions",
312 "location-api.json", 312 "location-api.json",
313 Manifest::COMPONENT, 313 Manifest::COMPONENT,
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 746
747 permissions_data->ClearTabSpecificPermissions(1); 747 permissions_data->ClearTabSpecificPermissions(1);
748 EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1)); 748 EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1));
749 749
750 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0)); 750 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
751 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1)); 751 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1));
752 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2)); 752 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
753 } 753 }
754 754
755 } // namespace extensions 755 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698