Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
404823009:
Removing the * from hosts and adding the words 'all' and 'site'. (Closed)
DescriptionRemoving the * from hosts and adding the words 'all' and 'site'.
Currently when an extension/app requests "*://*.google.com/*" permission they get the following install-time warning ".. your data on *.google.com". This CL will change the message to: ".. your data on all google.com sites"
BUG=362360
R=jww, meacer
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285178
Patch Set 1 #
Total comments: 1
Patch Set 2 : Adding internationalization support #
Total comments: 8
Patch Set 3 : Addressing kalman@ comments and fixing a broken test #
Total comments: 6
Patch Set 4 : Addressing jww@ comment (generalize the max size of list) #
Total comments: 6
Patch Set 5 : Second round of jww@ comments #
Total comments: 14
Patch Set 6 : Addressing kalman@ comments #
Total comments: 4
Patch Set 7 : Modifying the strings description #Patch Set 8 : Fixing a failing test #
Messages
Total messages: 36 (0 generated)
Hey jww@ and meacer@ can you please have a look at this for me.
https://codereview.chromium.org/404823009/diff/1/extensions/common/permission... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/1/extensions/common/permission... extensions/common/permissions/permission_message_util.cc:112: host = "all " + host + " sites"; this won't localise, you need to actually update the resource files.
Thanks for pointing that kalman@ it totally skipped my mind. Hope this round it better.
https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:45: std::vector<base::string16> khosts; why is this "khosts"? it seems like you can just change host_list to be a std::vector<string16> and iterate over |hosts| on line 48. https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:49: khosts.push_back(host_list[i][0] == '*' && host_list[i][1] == '.' does this behavioral change really not trigger any test failures? https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... extensions/extensions_strings.grd:211: all <ph name="WEBSITE_1">$1<ex>google.com</ex></ph> sites should this be "All" not "all"?
https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:88: message = l10n_util::GetPluralStringFUTF16(message_ids, host_list.size()); in your screenshot it says "read and modify your data on 4 websites", but then it's followed by "all google.com sites". that looks kinda wrong, but I can't think of how to improve it other than saying "many sites" instead of the actual number.
https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:49: khosts.push_back(host_list[i][0] == '*' && host_list[i][1] == '.' On 2014/07/21 23:41:08, kalman wrote: > does this behavioral change really not trigger any test failures? I haven't run the tests yet. I will do so as soon as we pass the iterations of change. https://codereview.chromium.org/404823009/diff/20001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:88: message = l10n_util::GetPluralStringFUTF16(message_ids, host_list.size()); On 2014/07/21 23:43:52, kalman wrote: > in your screenshot it says "read and modify your data on 4 websites", but then > it's followed by "all http://google.com sites". that looks kinda wrong, but I can't > think of how to improve it other than saying "many sites" instead of the actual > number. I see your point. I will go ahead and change it to "many sites". https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... extensions/extensions_strings.grd:211: all <ph name="WEBSITE_1">$1<ex>google.com</ex></ph> sites On 2014/07/21 23:41:08, kalman wrote: > should this be "All" not "all"? this is in the middle of the sentence. I will make some changes to make it say "All" when we have a list longer than 3.
https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... extensions/extensions_strings.grd:211: all <ph name="WEBSITE_1">$1<ex>google.com</ex></ph> sites On 2014/07/21 23:50:53, mhm wrote: > On 2014/07/21 23:41:08, kalman wrote: > > should this be "All" not "all"? > > this is in the middle of the sentence. I will make some changes to make it say > "All" when we have a list longer than 3. if something is in the middle of the sentence that might not be good for localisation either.
On 2014/07/21 23:52:33, kalman wrote: > https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... > File extensions/extensions_strings.grd (right): > > https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... > extensions/extensions_strings.grd:211: all <ph > name="WEBSITE_1">$1<ex>google.com</ex></ph> sites > On 2014/07/21 23:50:53, mhm wrote: > > On 2014/07/21 23:41:08, kalman wrote: > > > should this be "All" not "all"? > > > > this is in the middle of the sentence. I will make some changes to make it say > > "All" when we have a list longer than 3. > > if something is in the middle of the sentence that might not be good for > localisation either. If we remove that we need to add 10 extra string (1 for 1 host, 2 for 2 hosts, 6 for 3 hosts and 1 for 4 hosts) and the logic will be much more complicated.
On 2014/07/21 23:56:26, mhm wrote: > On 2014/07/21 23:52:33, kalman wrote: > > > https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... > > File extensions/extensions_strings.grd (right): > > > > > https://codereview.chromium.org/404823009/diff/20001/extensions/extensions_st... > > extensions/extensions_strings.grd:211: all <ph > > name="WEBSITE_1">$1<ex>google.com</ex></ph> sites > > On 2014/07/21 23:50:53, mhm wrote: > > > On 2014/07/21 23:41:08, kalman wrote: > > > > should this be "All" not "all"? > > > > > > this is in the middle of the sentence. I will make some changes to make it > say > > > "All" when we have a list longer than 3. > > > > if something is in the middle of the sentence that might not be good for > > localisation either. > > If we remove that we need to add 10 extra string (1 for 1 host, 2 for 2 hosts, 6 > for 3 hosts and 1 for 4 hosts) and the logic will be much more complicated. Your change isn't actually changing this right? Or is it? because the current behavior is to put them in bullet points (sort of) and that's probably fine. The current behaviour capitalises, though.
> Your change isn't actually changing this right? Or is it? because the current > behavior is to put them in bullet points (sort of) and that's probably fine. The > current behaviour capitalises, though. We have two cases; comma-list (3 or less hosts) and list (> 4 hosts). Capitalization is not the issue. The issue if we don't use this inner string for localization. This is the reason where we will have an explosion of strings.
On 2014/07/22 00:08:22, mhm wrote: > > Your change isn't actually changing this right? Or is it? because the current > > behavior is to put them in bullet points (sort of) and that's probably fine. > The > > current behaviour capitalises, though. > > We have two cases; comma-list (3 or less hosts) and list (> 4 hosts). > > Capitalization is not the issue. The issue if we don't use this inner string for > localization. This is the reason where we will have an explosion of strings. I see your point. The comma separation thing is new then?
oh it's not new, never mind.
Hopefully this round is better kalman@
https://codereview.chromium.org/404823009/diff/40001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/40001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:46: if (hosts.size() > 3) I really, really don't like hard coded numbers like this. Especially when combined with the switch statement below, it means that if we ever decide that "3" is no longer the magical number of what looks pretty, we'll have to refactor all the code, not just a set of constants. Obviously, it was already sort of like this, but this seems like as good an opportunity to change it as any :-) May I suggest that, instead, you create a value of something like uint_t kMaxBeforeManyMessage = 3, then instead of the switch statement, you create a static array of pairs std::pair<PermissionMessage, string16> that hold the default messages, and you can then check: if (host_list.size() < kMaxBeforeManyMessage) { message_id = pairs[host_list.size()][0]; message = pairs[host_list.size()][1]; } else { message_id = PermissionMessage::kHostsMore; message = IDS_EXTENSION_PROMPT_WARING_HOSTS_MORE_HOSTS; } https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... extensions/extensions_strings.grd:210: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN" desc="Permission string for for access to data on a website and its sub-domains."> I don't know much about localization, so maybe kalman@ can comment, but you are deleting a whole bunch of information pertaining to other languages here. We should tread carefully.
https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... extensions/extensions_strings.grd:210: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN" desc="Permission string for for access to data on a website and its sub-domains."> On 2014/07/22 16:20:31, jww wrote: > I don't know much about localization, so maybe kalman@ can comment, but you are > deleting a whole bunch of information pertaining to other languages here. We > should tread carefully. I'm not a localisation expert either, but these comments do look important. Perhaps look up the commit history of this file?
https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... extensions/extensions_strings.grd:210: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN" desc="Permission string for for access to data on a website and its sub-domains."> So these are different messages that are needed (along with their comments) when we are showing the number of hosts because the way different languages show different numbers. Since we are not showing the number of hosts any more and replacing that with the phrase "a number of websites" (check the previous discussion with kalman@) we don't need these complicated rules for how to show numbers any more.
https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/40001/extensions/extensions_st... extensions/extensions_strings.grd:210: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN" desc="Permission string for for access to data on a website and its sub-domains."> On 2014/07/22 17:09:05, mhm wrote: > So these are different messages that are needed (along with their comments) when > we are showing the number of hosts because the way different languages show > different numbers. Since we are not showing the number of hosts any more and > replacing that with the phrase "a number of websites" (check the previous > discussion with kalman@) we don't need these complicated rules for how to show > numbers any more. Acknowledged.
jww@ please have a look at this now. https://codereview.chromium.org/404823009/diff/40001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/40001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:46: if (hosts.size() > 3) On 2014/07/22 16:20:31, jww wrote: > I really, really don't like hard coded numbers like this. Especially when > combined with the switch statement below, it means that if we ever decide that > "3" is no longer the magical number of what looks pretty, we'll have to refactor > all the code, not just a set of constants. > > Obviously, it was already sort of like this, but this seems like as good an > opportunity to change it as any :-) May I suggest that, instead, you create a > value of something like uint_t kMaxBeforeManyMessage = 3, then instead of the > switch statement, you create a static array of pairs > std::pair<PermissionMessage, string16> that hold the default messages, and you > can then check: > > if (host_list.size() < kMaxBeforeManyMessage) { > message_id = pairs[host_list.size()][0]; > message = pairs[host_list.size()][1]; > } else { > message_id = PermissionMessage::kHostsMore; > message = IDS_EXTENSION_PROMPT_WARING_HOSTS_MORE_HOSTS; > } Done.
https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:45: uint32_t kMaxBeforeListOfHosts = 3; This should be const, I think. https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:46: std::vector<std::pair<PermissionMessage::ID, base::string16> > kMessagesList; I don't see why this needs to be a vector since it's basically static content that you're pushing onto it. In fact, by making it a vector, you're basically reintroducing the "code-rather-than-data" problem I was trying to avoid in the previous comment. Can you make this a static array of pairs? Something like: const std::pair<int, int>kList[kMaxBeforeListOfHosts] = { std::pair<int, int>(1, 2), std::pair<int, int>(2, 3), std::pair<int, int>(3, 4) }; Obviously, the pairs should not be of ints but should be of the proper types you're working with :-)
https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:46: std::vector<std::pair<PermissionMessage::ID, base::string16> > kMessagesList; So the main issue here is that to be able to create the pair, the second element requires we know the host_list which is computed inside this function. We use a different string for each of the three options as each one has a different number of placers. I don't how this can be converted to pure data.
https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:46: std::vector<std::pair<PermissionMessage::ID, base::string16> > kMessagesList; On 2014/07/22 21:53:34, mhm wrote: > So the main issue here is that to be able to create the pair, the second element > requires we know the host_list which is computed inside this function. We use a > different string for each of the three options as each one has a different > number of placers. > > I don't how this can be converted to pure data. Ah, I see. Well, you can still do something more extensible, I think, by making the data pairs of PermissionMessages and base::string16s, and calling l10n_util::GetStringFUTF16 when you extract .second from the pairs. So you'll initialize with something like: const std::pair<PermissionMessage, base::string16>kList[kMaxBeforeListOfHosts] = { std::pair<PermissionMessage, base::string16>( PermissionMessage::kHosts1, IDS_EXTENSION_PROMPT_WARNING_1_HOST), ... }; then later message_id = kMessagesList[host_list.size() - 1].first; message = l10n_util::GetStringFUTF16(kMessagesList[host_list.size() - 1].second, host_list, NULL); You'll probably want to typdef the pair type since it's kinda ugly though :-)
jww@ please have a look at this for me. https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:45: uint32_t kMaxBeforeListOfHosts = 3; On 2014/07/22 21:31:56, jww wrote: > This should be const, I think. Done. https://codereview.chromium.org/404823009/diff/60001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:46: std::vector<std::pair<PermissionMessage::ID, base::string16> > kMessagesList; On 2014/07/22 22:14:35, jww wrote: > On 2014/07/22 21:53:34, mhm wrote: > > So the main issue here is that to be able to create the pair, the second > element > > requires we know the host_list which is computed inside this function. We use > a > > different string for each of the three options as each one has a different > > number of placers. > > > > I don't how this can be converted to pure data. > > Ah, I see. Well, you can still do something more extensible, I think, by making > the data pairs of PermissionMessages and base::string16s, and calling > l10n_util::GetStringFUTF16 when you extract .second from the pairs. So you'll > initialize with something like: > > const std::pair<PermissionMessage, base::string16>kList[kMaxBeforeListOfHosts] = > { > > std::pair<PermissionMessage, base::string16>( > PermissionMessage::kHosts1, > IDS_EXTENSION_PROMPT_WARNING_1_HOST), > ... > }; > > then later > > message_id = kMessagesList[host_list.size() - 1].first; > message = l10n_util::GetStringFUTF16(kMessagesList[host_list.size() - 1].second, > host_list, NULL); > > You'll probably want to typdef the pair type since it's kinda ugly though :-) Done.
lgtm
kalman@ can you please owner review this for me?
sorry. https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:44: base::string16 details; nits: declare these 3 (or 2) variables only when you need them. https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:45: const uint32_t kMaxBeforeListOfHosts = 3; size_t? https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:50: const MsgPair kMessagesList[kMaxBeforeListOfHosts + 1] = { do you even need to specify a size here? I would have thought you can just go const MsgPair kMessagesList[] = { ... }; the nice part about that is then you can get rid of kMaxBeforeListOfHosts entirely and use arraysize(kMessagesList) when needed (very slightly different logic needed of course). https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:72: if (host_list.size() <= kMaxBeforeListOfHosts) { this could be a bit simpler if you used a MsgPair rather than unwrapping them into a message and message_id. https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... extensions/extensions_strings.grd:210: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN" desc="Permission string for for access to data on a website and its sub-domains."> s/for for/for/ but you could say "Permission string requesting access..." https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... extensions/extensions_strings.grd:213: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN_LIST" desc="Permission string for for access to data on a website and its sub-domains when we have more than 4 hosts and the first letter should be capital."> ditto https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... extensions/extensions_strings.grd:216: <message name="IDS_EXTENSION_PROMPT_WARNING_HOSTS_4_OR_MORE_HOSTS" desc="Permission string for access to data on four or more websites."> I wonder if we should really be using the term "four" in here (and 4 in the constant name). at this point it's not about a number but about some indeterminate collection of websites, so 4 is an implementation detail and not actually correct.
Thanks for the comments kalman@ Hopefully this round is better https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... File extensions/common/permissions/permission_message_util.cc (right): https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:44: base::string16 details; On 2014/07/23 01:32:45, kalman wrote: > nits: declare these 3 (or 2) variables only when you need them. Done. https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:45: const uint32_t kMaxBeforeListOfHosts = 3; On 2014/07/23 01:32:45, kalman wrote: > size_t? Done. https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:50: const MsgPair kMessagesList[kMaxBeforeListOfHosts + 1] = { On 2014/07/23 01:32:45, kalman wrote: > do you even need to specify a size here? I would have thought you can just go > > const MsgPair kMessagesList[] = { > ... > }; > > the nice part about that is then you can get rid of kMaxBeforeListOfHosts > entirely and use arraysize(kMessagesList) when needed (very slightly different > logic needed of course). Done. https://codereview.chromium.org/404823009/diff/80001/extensions/common/permis... extensions/common/permissions/permission_message_util.cc:72: if (host_list.size() <= kMaxBeforeListOfHosts) { On 2014/07/23 01:32:45, kalman wrote: > this could be a bit simpler if you used a MsgPair rather than unwrapping them > into a message and message_id. Done. https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... extensions/extensions_strings.grd:210: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN" desc="Permission string for for access to data on a website and its sub-domains."> On 2014/07/23 01:32:45, kalman wrote: > s/for for/for/ > > but you could say "Permission string requesting access..." Done. https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... extensions/extensions_strings.grd:213: <message name="IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN_LIST" desc="Permission string for for access to data on a website and its sub-domains when we have more than 4 hosts and the first letter should be capital."> On 2014/07/23 01:32:45, kalman wrote: > ditto Done. https://codereview.chromium.org/404823009/diff/80001/extensions/extensions_st... extensions/extensions_strings.grd:216: <message name="IDS_EXTENSION_PROMPT_WARNING_HOSTS_4_OR_MORE_HOSTS" desc="Permission string for access to data on four or more websites."> On 2014/07/23 01:32:45, kalman wrote: > I wonder if we should really be using the term "four" in here (and 4 in the > constant name). at this point it's not about a number but about some > indeterminate collection of websites, so 4 is an implementation detail and not > actually correct. Done.
lgtm https://codereview.chromium.org/404823009/diff/100001/extensions/extensions_s... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/100001/extensions/extensions_s... extensions/extensions_strings.grd:216: <message name="IDS_EXTENSION_PROMPT_WARNING_HOSTS_LIST" desc="Permission string for access to data for an expandable list of websites."> could you say "arbitrary number" rather than "expandable list"? seems like that'd be more useful to translators.
https://codereview.chromium.org/404823009/diff/100001/extensions/common/permi... File extensions/common/permissions/permissions_data_unittest.cc (right): https://codereview.chromium.org/404823009/diff/100001/extensions/common/permi... extensions/common/permissions/permissions_data_unittest.cc:303: EXPECT_EQ("Read and modify your data on a number of websites", actually hold up - is it just me or are there surprisingly few test changes you've needed to make considering the changes you made to the code?
https://codereview.chromium.org/404823009/diff/100001/extensions/common/permi... File extensions/common/permissions/permissions_data_unittest.cc (right): https://codereview.chromium.org/404823009/diff/100001/extensions/common/permi... extensions/common/permissions/permissions_data_unittest.cc:303: EXPECT_EQ("Read and modify your data on a number of websites", On 2014/07/23 15:25:23, kalman wrote: > actually hold up - is it just me or are there surprisingly few test changes > you've needed to make considering the changes you made to the code? I ran all the unit tests locally and all of them passed. I will see if any of the bots fail when committed. https://codereview.chromium.org/404823009/diff/100001/extensions/extensions_s... File extensions/extensions_strings.grd (right): https://codereview.chromium.org/404823009/diff/100001/extensions/extensions_s... extensions/extensions_strings.grd:216: <message name="IDS_EXTENSION_PROMPT_WARNING_HOSTS_LIST" desc="Permission string for access to data for an expandable list of websites."> On 2014/07/23 02:48:49, kalman wrote: > could you say "arbitrary number" rather than "expandable list"? seems like > that'd be more useful to translators. Done.
The CQ bit was checked by mohammed@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/404823009/120001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by mohammed@chromium.org
The CQ bit was checked by mohammed@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/404823009/140001
Message was sent while issue was closed.
Change committed as 285178 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
