Remove some very old-file-format code from safe browsing store.

Remove some very old-file-format code from safe browsing store.

In 2010 safe-browsing storage was rewritten to use a binary format
instead of SQLite, with support for SQLite removed in 2011 (r74253).
Remove the code which detects and histograms this, as there is no
possibility that anything will be done with that data.

Additionally, remove code to delete even older SQLite files left from
the original safe-browsing implementation.  This code is firing a few
thousand times per month, but it is hard to imagine any scenario where
profiles that continue to contain this data are not horribly broken.

BUG=none
R=asvitkine@chromium.org, feng@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285389

[Scott Hess - ex-Googler, 2014-07-18 20:45:52]

I usually snag Matt for these cleanups, but he's OOT, so since you've been
working in the code more than a randomly-selected Chromium developer, could you
take a look?

[Feng Qian, 2014-07-18 21:11:46]

On 2014/07/18 20:45:52, Scott Hess wrote:
> I usually snag Matt for these cleanups, but he's OOT, so since you've been
> working in the code more than a randomly-selected Chromium developer, could
you
> take a look?

I never looked at these files before. The change seems straightforward.

lgtm

[Scott Hess - ex-Googler, 2014-07-18 21:28:19]

On 2014/07/18 21:11:46, Feng Qian wrote:
> On 2014/07/18 20:45:52, Scott Hess wrote:
> > I usually snag Matt for these cleanups, but he's OOT, so since you've been
> > working in the code more than a randomly-selected Chromium developer, could
> you
> > take a look?
> 
> I never looked at these files before. The change seems straightforward.

Yeah, but you're unlikely to lose your mind because you don't know what "safe
browsing" is :-).

> lgtm

Thanks.

[Scott Hess - ex-Googler, 2014-07-18 21:28:22]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-07-18 21:29:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shess@chromium.org/404803006/1

[commit-bot: I haz the power, 2014-07-19 01:11:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-19 01:15:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-19 01:15:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Scott Hess - ex-Googler, 2014-07-22 23:32:36]

Oops - OWNERS for histograms.xml?

[Alexei Svitkine (slow), 2014-07-23 14:41:16]

https://codereview.chromium.org/404803006/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_store_file.cc (left):

https://codereview.chromium.org/404803006/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_store_file.cc:641:
UMA_HISTOGRAM_COUNTS("SB2.OldDatabaseKilobytes",
Can you mark this histogram with an <obsolete> tag in histograms.xml?

[Scott Hess - ex-Googler, 2014-07-23 17:18:19]

https://codereview.chromium.org/404803006/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/safe_browsing_store_file.cc (left):

https://codereview.chromium.org/404803006/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/safe_browsing_store_file.cc:641:
UMA_HISTOGRAM_COUNTS("SB2.OldDatabaseKilobytes",
On 2014/07/23 14:41:16, Alexei Svitkine wrote:
> Can you mark this histogram with an <obsolete> tag in histograms.xml?

Done.

[Scott Hess - ex-Googler, 2014-07-24 17:42:30]

On 2014/07/23 17:18:19, Scott Hess wrote:
>
https://codereview.chromium.org/404803006/diff/1/chrome/browser/safe_browsing...
> File chrome/browser/safe_browsing/safe_browsing_store_file.cc (left):
> 
>
https://codereview.chromium.org/404803006/diff/1/chrome/browser/safe_browsing...
> chrome/browser/safe_browsing/safe_browsing_store_file.cc:641:
> UMA_HISTOGRAM_COUNTS("SB2.OldDatabaseKilobytes",
> On 2014/07/23 14:41:16, Alexei Svitkine wrote:
> > Can you mark this histogram with an <obsolete> tag in histograms.xml?
> 
> Done.

PTAL (Alexei)?

[Alexei Svitkine (slow), 2014-07-24 17:59:53]

lgtm

[Scott Hess - ex-Googler, 2014-07-24 18:05:06]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-07-24 18:08:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shess@chromium.org/404803006/20001

[commit-bot: I haz the power, 2014-07-24 21:24:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-24 21:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 21:58:39]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[Scott Hess - ex-Googler, 2014-07-24 22:16:53]

Committed patchset #2 manually as r285389 (presubmit successful).