Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 404803006: Remove some very old-file-format code from safe browsing store. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: deprecate SB2.OldDatabaseKilobytes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 717ca5d79b8bf96a1be5a04a2709221968515d69..053db277e08bf9ca66433d0e165809b29776555c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -25636,6 +25636,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.OldDatabaseKilobytes" units="KB">
+ <obsolete>
+ Deprecated 7/2014. No longer generated.
+ </obsolete>
<owner>shess@chromium.org</owner>
<summary>Size of v1 database deleted from client profile.</summary>
</histogram>
@@ -45862,17 +45865,39 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="SB2FormatEvent" type="int">
- <int value="0" label="FILE_CORRUPT"/>
- <int value="1" label="SQLITE_CORRUPT"/>
- <int value="2" label="FOUND_SQLITE"/>
- <int value="3" label="FOUND_UNKNOWN"/>
- <int value="4" label="SQLITE_DELETED"/>
- <int value="5" label="SQLITE_DELETE_FAILED"/>
- <int value="6" label="SQLITE_DELETED_ORIGINAL"/>
- <int value="7" label="SQLITE_DELETE_ORIGINAL_FAILED"/>
- <int value="8" label="VALIDITY_CHECKSUM_FAILURE"/>
- <int value="9" label="UPDATE_CHECKSUM_FAILURE"/>
- <int value="10" label="HEADER_CHECKSUM_FAILURE"/>
+ <summary>
+ Track information for various error cases in the safe-browsing store.
+ </summary>
+ <int value="0" label="FILE_CORRUPT">Store corruption detected</int>
+ <int value="1" label="SQLITE_CORRUPT">
+ SQLite store orruption detected (obsolete)
+ </int>
+ <int value="2" label="FOUND_SQLITE">SQLite store found (obsolete)</int>
+ <int value="3" label="FOUND_UNKNOWN">Store format unknown at open</int>
+ <int value="4" label="SQLITE_DELETED">
+ Deleted SQLite-format store (obsolete)
+ </int>
+ <int value="5" label="SQLITE_DELETE_FAILED">
+ Deletion of SQLite-format store failed (obsolete)
+ </int>
+ <int value="6" label="SQLITE_DELETED_ORIGINAL">
+ Deleted pre-release SQLite store (obsolete)
+ </int>
+ <int value="7" label="SQLITE_DELETE_ORIGINAL_FAILED">
+ Deletion of pre-release SQLite store failed (obsolete)
+ </int>
+ <int value="8" label="VALIDITY_CHECKSUM_FAILURE">
+ Failed explicit checksum check on failed update from server
+ </int>
+ <int value="9" label="UPDATE_CHECKSUM_FAILURE">
+ Failed checksum check while merging new data into store
+ </int>
+ <int value="10" label="HEADER_CHECKSUM_FAILURE">
+ Failed header checksum check when opening store
+ </int>
+ <int value="11" label="FOUND_DEPRECATED">
+ Store with valid magic number has deprecated version number
+ </int>
</enum>
<enum name="SB2GetHashResult" type="int">
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698